microsoft / microsoft/terminal

MediaResource: Recursively expanded commands are ignored, overwritten commands are still resolved

Open
#19,201 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-CodeHealth Area-Settings Issue-Task Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

It's too much work right now to move media resolution to after command expansion (for the first case) and after ActionMap handles all of its final resolution (to prevent deleted/changed commands from also getting resolved). Taking this as a TODO health item.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing MediaResource, recursive command expansion, and ActionMap's final resolution; done means recursively expanded commands are handled and overwritten or deleted commands are not resolved afterward.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.