microsoft / microsoft/terminal
MediaResource: Hardcoded OriginTags for things which could only be set in the user settings file.
Open
Nobody has claimed this yet.
Area-CodeHealth
Area-Settings
Issue-Task
Product-Terminal
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Some of the settings model objects we upgraded to use MediaResource in #19143 _only ever appeared in the User's settings file_, so they never had an `Origin`.
We hardcoded an `OriginTag` of `User` for them to pass during resource resolution.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the MediaResource changes from #19143 and the settings model objects that only appear in the User's settings file. Trace how resource resolution handles OriginTags and determine the intended behavior for resources without an Origin. Done means those objects no longer rely on an inappropriate hardcoded User tag while still resolving correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100