microsoft / microsoft/terminal
{Freeway-Bug} [Windows Terminal - Settings]: Correct role as link should be defined for 'Open JSON file' control.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
### Windows Terminal version
1.23.10732.0
### Windows build number
27823.1000
### Other Software
**Test Environment:**
OS: Windows 11 Version Dev (OS Build 27823.1000)
App: Windows Terminal Preview
Screen Reader: Narrator
### Steps to reproduce
**Repro steps:**
1. Open the 'windows terminal' application.
2. Turn on Narrator by pressing 'Ctrl + Windows + Enter' keys.
3. Navigate to the 'Settings' page.
4. Now navigate to the 'Open JSON file' control by tab key and activate it.
5. Observe the behavior when opening the file in the selected editor (e.g., Notepad).
6. Close or minimize the editor and observe the state of the 'Open JSON file' control.
**User experience:**
Users may be confused by the current role assignment, as a list item suggests selection rather than activation. This misinterpretation can cause uncertainty when interacting with the control, leading to difficulty understanding its intended function. Defining the correct role as a link would improve accessibility and usability.
**Attachment:**
[Correct role as link should be defined for 'Open JSON file' control..zip](https://github.com/user-attachments/files/19648119/Correct.role.as.link.should.be.defined.for.Open.JSON.file.control.zip)
### Expected Behavior
The 'Open JSON file' control should be assigned the correct role as a link instead of a list item. Additionally, an 'Open in new window' sign or appropriate information should be associated with it to ensure clarity for users. When activated, the control should behave like a proper link and not remain visually selected when the editor is closed or minimized.
### Actual Behavior
The 'Open JSON file' control is currently defined with the role of a list item instead of a link. Upon activation, the JSON file opens in the selected editor (e.g., Notepad), but the control remains visually selected even after the editor is closed or minimized. This behavior creates confusion for users, as the control does not behave as a typical link.
Contributor guide
Research direction
Start by reproducing the issue on the Settings page with Narrator, focusing on the 'Open JSON file' control and its behavior after the editor closes or is minimized. Locate the Settings implementation for this control, then verify that its announced role and activation state match the expected link behavior and that the control is no longer incorrectly shown as selected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- accessibility
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100