microsoft / microsoft/terminal

Line height does not apply to legacy computing symbols

Open
#18,498 6 comments 0 reactions 1 assignee Claimed by @lhecker View on GitHub
Area-Rendering Issue-Task Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

### Windows Terminal version

1.21.3231.0

### Windows build number

10.0.19045.0

### Other Software

- Ubuntu 22.04.5 LTS (WSL2)
- [Cascadia Code 2407.24](https://github.com/microsoft/cascadia-code/releases/tag/v2407.24) Nerd Font

### Steps to reproduce

Printing legacy computing symbols (using a font that supports them), such as `▔🮂🮃▀🮄🮅🮆█ █🮋🮊🮉▐🮈🮇▕ ▏🭰🭱🭲🭳🭳🭵▕` and increase the font line height (`cellHeight` setting in the JSON).

### Expected Behavior

There should be no visible gaps between the characters, either vertically or horizontally, as it is for block elements:

1.1 line height
![Image](https://github.com/user-attachments/assets/536ab7e5-709c-443d-ae6d-049eb70e8947)

1.5 line height
![Image](https://github.com/user-attachments/assets/ff9a4e51-6aab-46b6-a54c-9f48db2fd979)

### Actual Behavior

Legacy computing symbols have noticeable vertical gaps when increasing the line height. There are also smaller horizontal gaps.

1.1 line height
![Image](https://github.com/user-attachments/assets/40774338-b50b-4181-8d7c-6fd7daa143de)

1.5 line height
![Image](https://github.com/user-attachments/assets/4ad5a616-3ce1-4848-9e3f-0a2e5cccf92b)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.