microsoft / microsoft/terminal
UIA notifications are incorrect for git output
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
### Windows Terminal version
Windows Terminal Canary Version: 1.23.10282.0
### Windows build number
10.0.22631.4751
### Other Software
Git 2.44.0
### Steps to reproduce
1. Download git 2.43 from https://github.com/git-for-windows/git/releases/download/v2.43.0.windows.1/PortableGit-2.43.0-64-bit.7z.exe
2. Download git 2.44 from https://github.com/git-for-windows/git/releases/download/v2.44.0-rc0.windows.1/PortableGit-2.44.0-rc0-64-bit.7z.exe
3. Extract downloaded 2.43 and 2.44 versions somewhere.
4. Open a tab in the windows terminal (cmd or power shell).
5. cd to the git 2.43/bin directory.
6. Launch the windows narrator (ctrl+win+enter).
7. Execute `git` without arguments.
8. cd to the git 2.44/bin directory.
9. Execute `git` without arguments.
### Expected Behavior
Git usage should be spoken without obvious interruptions in the middle of the words in every git version.
At least the word "usage" should be distinctly audible from the Narrator.
### Actual Behavior
When using git 2.43 (step 7), behavior is normal and expected, there is no problems.
When using git 2.44 (step 9) The Narrator speaks "u", and then "sage" with a small noticeable pause.
More detailed debugging with the NVDA screenreader showed that after the first character in each line of the git output, an additional line feed (\n) is added, which is not visible on the screen, but is in UIA Notification.
This problem is reproducible on the latest stable version of git for windows 2.47, as well as in latest Windows Terminal Preview.
@carlos-zamora
Contributor guide
Research direction
Start by reproducing the issue with Git 2.43 and 2.44 or later in Windows Terminal while observing Narrator or NVDA UIA notifications. Compare the visible output with the notifications and verify that Git output no longer inserts an extra line feed after the first character of each line.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git
- Domain
- accessibility
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100