microsoft / microsoft/terminal
SUI Nullable Colors & Icon control Follow-ups
@carlos-zamora is already working on this.
Since Dec 12, 2024.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Follow-ups from #17870:
- [x] [A11y] Screen readers don't read expander's preview text
- Tracked in https://github.com/microsoft/microsoft-ui-xaml/issues/10282
- ~Hmm... it might be better to just directly set the `AutomationProperty.Name`~
- PR #18418
- [x] Add Tab Color to settings UI
- PR #19351
- [ ] Update CursorColor preview to display #FFFFFF as "invert"
- [X] Use Leonard's font picker UI, with the Segoe icon picker, so that you can filter the list
- PR #19569
- [ ] [High contrast] we should probably add borders to the color chip previews
### From Bug bash 1/21
- [ ] [Windows 10] Conflicting Windows & app theme causes this:
- [x] [Windows 10] Checkmark icon is missing!
- [x] Narrow window = cut off
- [ ] When using an emoji for the Profile icon, I run into this while using certain emojis (shield) though that might just be an issue with the emoji itself (not our problem?)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.