microsoft / microsoft/terminal
Restoring exited panes should not restart them
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
# Description of the new feature/enhancement
* Have session persistence enabled
* Have a pane that has exited but wasn't closed, because the termination behavior is "never", etc.
* Restart Windows Terminal
* Suddenly all those tabs are running again
We should avoid restarting such tabs.
# Proposed technical implementation details (optional)
The state.json should store whether a pane has exited. If it had then it should not restart it automatically.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how session persistence reads state.json during Windows Terminal startup, using the reproduction steps in the issue. Check how exited panes are represented and restored. Done means panes that had already exited remain exited instead of being restarted automatically after a restart.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 40/100