microsoft / microsoft/terminal
Add an option to revert to old alpha-based selection colors
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
In v1.22, selection colors were changed significantly to make the selection have uniform foreground and background color. However, the new colors are imo hard to read due to excessive contrast and they interact poorly with text with varying background and foreground color (see image 4 and 5). Also, using glyphs to create rounded corners on blocks with different background colors breaks with the new selection behavior (see image 3).
Personally, I much prefer the previous alpha-based selection. Could you add an option to revert to the previous behavior?
v1.21, the pretty alpha-based selection:
v1.22, too much contrast, imo does not look as good:
---
Bad rendering for rounded corners using glyphs:
---
v1.22 hides all background colors:
v1.21 preserves background colors, which imo looks better:
Contributor guide
Research direction
No files, tests, or entry points are named. Start by comparing the selection rendering behavior between v1.21 and v1.22, then identify where selection colors are configured; done means an option restores the alpha-based behavior while preserving background colors and glyph-based rounded corners.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100