microsoft / microsoft/terminal
Display more info for WinGet suggestions
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
> okay a minor thought: In 1.22 I added `Description`'s to `Command`s. If the package catalog gives us a description, we could totally stick that in the teaching tip 👀
>
> Similarly, IMO, we don't need `--source winget` in the `Name` of the Command. It's clearer to just say `winget install Foo` and have the rest of the args in the preview text (but that's just my opinion)
from https://github.com/microsoft/terminal/pull/17614#pullrequestreview-2248962767
### Implementation
Should be pretty straightforward to do, but we need to make a few changes to make this happen:
- [ ] Currently, `ControlCore` stores the suggestions as an `IVector`. We'll need to change that to be able to hold the winget metadata (package description and simplified package name)
- [ ] `TerminalPage::_PopulateQuickFixMenu` needs to be updated to display the metadata
- [ ] `TerminalPage::_doHandleSuggestions` needs to be updated to display the metadata
Contributor guide
Research direction
Start by tracing how ControlCore stores the current IVector suggestions, then inspect TerminalPage::_PopulateQuickFixMenu and TerminalPage::_doHandleSuggestions. Update the suggestion data flow to retain the winget package description and simplified name, and verify that both suggestion displays show the metadata and simplified command form.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100