microsoft / microsoft/terminal
ConPTY sends two `WINDOW_BUFFER_SIZE_EVENT` messages when the window is restored from maximize
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
I think I found one resize bug. A ConPTY sends two WINDOW_BUFFER_SIZE_EVENT messages when the window is restored from maximize, but the first one has the wrong size (not sure of the internals of this, but it appears in conhost/tmux/pwsh, alacritty/pwsh, and Windows Terminal).
Run this program as conevents -es in conhost and a different terminal to see the difference; maximize and restore the window. For example, restoring the WinTerm window reports 119 x 46 in the WINDOW_BUFFER_SIZE_EVENT message, but GetConsoleScreenBufferInfo returns the correct value 119 x 32.
Originally posted by @parkovski in https://github.com/microsoft/terminal/issues/1465#issuecomment-506924361
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Run conevents.cpp as conevents -es in conhost and another terminal, then maximize and restore the window to reproduce the two WINDOW_BUFFER_SIZE_EVENT messages. Compare the reported event sizes with GetConsoleScreenBufferInfo, using the 119 x 46 versus 119 x 32 example as the reference. Done means restoring the window produces the correct size without an incorrect duplicate event.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100