microsoft / microsoft/terminal
Windows Terminal crashes when combining duplicateTab with moveTab in multipleActions
@zadjii-msft is already working on this.
Since Jul 10, 2024.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Windows Terminal version
1.21.1272.0
Windows build number
Microsoft Windows [Version 10.0.22631.3593]
Other Software
No response
Steps to reproduce
- Include this snippet in your
settings.json:
{
"command":
{
"action": "multipleActions",
"actions":
[
{
"action": "duplicateTab"
},
{
"action": "moveTab",
"window": "new"
}
]
},
"keys": "ctrl+shift+f12"
},
- Open Windows Terminal
- Press Ctrl+Shift+F12
- See it crash.
Expected Behavior
I was hoping to create a new entry with multipleActions to 1. duplicate the current tab into a new tab, 2. move it to its own window. @zadjii-msft had proposed this great workaround as a way to clone the current tab into a new window, in https://github.com/microsoft/terminal/issues/14350#issuecomment-1304809041.
Actual Behavior
Windows Terminal crashes.
Noting that using multipleActions with just the duplicateTab action works, but it only duplicates the tab.
Similarly, referencing just the moveTab action works.
Combining them both in multipleActions causes Terminal to crash.
There was a similar bug where manipulating tabs as part of multipleActions was causing issues:
https://github.com/microsoft/terminal/issues/11107
And there was a fix to the way Windows Terminal handled tab movement in multipleActions.
https://github.com/microsoft/terminal/pull/11144
Maybe a similar problem still exists when creating a new tab as part of multipleActions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.