microsoft / microsoft/terminal

No longer use Command.Name for disambiguation

Open
#17,166 0 comments 0 reactions 1 assignee Claimed by @PankajBhojwani View on GitHub
Area-CodeHealth Issue-Task Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

# Description of the new feature/enhancement
Once #17162 merges, we will have unique `ActionID`s for command disambiguation. This means we no longer need to use `Command.Name` for disambiguation and should update the following accordingly: `Command`, `ActionMap`, `SettingsEditor`, `CommandPalette`

# Proposed technical implementation details (optional)
Any location where we use `Command.Name` to disambiguate commands we should be using their IDs instead

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.