microsoft / microsoft/terminal
If state.json contains any unknown dismissed message keys, we crash
Open
Area-CodeHealth
Area-Settings
Issue-Bug
Priority-3
Product-Terminal
Severity-Crash
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
This means we cannot easily deprecate keys. I've worked around it in #16873.
Contributor guide
Research direction
Start by examining how dismissed message keys in state.json are read and compare the workaround described in issue #16873. The work is done when unknown dismissed-message keys no longer cause a crash and existing known keys continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100