microsoft / microsoft/terminal

Windows Terminal text overlaps in some GB18030-2022 Chinese Standard Code Characters

Open
#16,779 3 comments 0 reactions 0 assignees View on GitHub
Area-Rendering Issue-Bug Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

### Windows Terminal version

1.19.10573.0

### Windows build number

10.0.22621.3155

### Other Software

_No response_

### Steps to reproduce

- Change System Locale to `Chinese (Simplified, China)` and Restart your machine
- Control Panel -> Clock & Region -> Region (Administrative) -> Change system locale to Chinese (Simplified, China)
- New a Windows Terminal of PowerShell/cmd (The default chcp code page is 936 according to the system locale)
- Copy some GB18030-2022 Chinese Standard Code Characters `①Ⅻㄨㄩ啊阿鼾齄丂丄狚狛狜狝﨨﨩ˊˋ˙–⿻〇` to the terminal and verify if the test character set can be rendered well.

### Expected Behavior

Each character can be rendered individually in the terminal.

### Actual Behavior

Both PowerShell and cmd have some glyphs overlapping.

![image](https://github.com/microsoft/vscode/assets/14052197/d3a0955d-a2cc-4a26-9737-5ca9e6b1e0a8)

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the overlap with the listed GB18030-2022 characters under the specified Chinese system locale, Windows build, and Windows Terminal version. Trace the terminal text-rendering path from that reproduction; done means each test character renders individually in both PowerShell and cmd without overlapping glyphs.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.