microsoft / microsoft/terminal
Use default page transition for settings pages instead of drill-in transition
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
# Description of the new feature/enhancement
The settings content frame currently specifies `DrillInNavigationTransitionInfo` as content transition mode: https://github.com/microsoft/terminal/blob/d14524cd4cc4970bb1b6456f9667e2dd661b9854/src/cascadia/TerminalSettingsEditor/MainPage.xaml#L179
The drill-in effect, as its name suggests, is in my opinion suitable when navigating further down in a hierarchy (e.g. viewing a list of folders and navigating into a subfolder) but less appropriate when switching between settings pages which are on the same logical level.
Instead, I suggest to use the default page transition mode "slide from bottom", which is also used in the Windows Settings, and whose UI is very similar to the settings in Windows Terminal. By using the same transitions, Windows Terminal will feel more consistent with the inbuilt OS apps.
# Proposed technical implementation details (optional)
Replace lines https://github.com/microsoft/terminal/blob/d14524cd4cc4970bb1b6456f9667e2dd661b9854/src/cascadia/TerminalSettingsEditor/MainPage.xaml#L177-L181 with
```xaml
```
(There is a difference between specifying `` and not setting `Frame.ContentTransitions` at all. If it is not set at all, the Frame will still use the "slide from bottom" transition between page transitions as a default but it will not show the animation on initial displaying of the page. Since the Windows Settings app does show an animation on initial loading of the page, my suggestion is to do it here, as well.)
Contributor guide
Research direction
Start with src/cascadia/TerminalSettingsEditor/MainPage.xaml around lines 177-181 and inspect the settings content frame's ContentTransitions. Compare the existing transition with the proposed default navigation transition, then verify settings-page navigation and initial display use the intended animation; done when the settings pages no longer use drill-in behavior.
Written by the indexing model from the issue text.
Assessment
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100