microsoft / microsoft/terminal

`wt.exe` should accept env vars on the commandline

Open
#16,008 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Commandline Issue-Task Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

forked from #15496

wt -E foo=bar to manually pass env vars to the NewTerminalArgs. This'll let a caller manually pass env vars on the commandline. Great!

builds off the work in #15082. Basically, each of the -E foo=bar args would get collected by the arg parser, then eventually passed to TerminalSettings::CreateWithNewTerminalArgs. We'd layer them on top of anything from the profile.

open questions:

  • syntax?
  • What if I want to pass -E foo=%bar%, where bar is something defined in the profile's env block, but not the current one?
    • IMO we can just say no to this. This seems impossible, and also why?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the argument parser through TerminalSettings::CreateWithNewTerminalArgs, using the related work in #15082 and #15496 as context. Resolve the listed syntax and profile-environment questions, then verify that repeated -E foo=bar arguments are collected and layered over profile variables.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, operating-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.