microsoft / microsoft/terminal
Is the version info binary language ID supposed to be 0?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
WindowsTerminal.exe's version info resource has this block header (from devenv).
And it has this binary data in the translation entry (from devenv).
In particular the binary language identifier is 0x0000. That makes VerQueryValueW queries like this
`wsprintf(szQuery, L"\\StringFileInfo\\%04x%04x\\ProductVersion", lpTranslate[i].wLanguage, lpTranslate[i].wCodePage);`
fail when the language info comes from `VerQueryValueW(pData, L"\\VarFileInfo\\Translation", (LPVOID*) &lpTranslate, &ulen);`
because lpTranslate[i].wLanguage is 0.
My programming was based on the sample in the help for VerQueryValueW.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the WindowsTerminal.exe version-info resource and the VerQueryValueW calls shown in the report. Determine whether the 0x0000 language identifier is expected and what resource or documentation change, if any, is required; done should include a maintainer-confirmed explanation and a reproducible result for the ProductVersion query.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100