microsoft / microsoft/terminal
CONTROL+C on close instead of CONTROL_CLOSE_EVENT
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
# Description of the new feature/enhancement
on closing the x button send a control+c signal to all processes by default instead of terminating them.
Definition: the x button is described as both the x button for windows terminal itself and every tab
# Proposed technical implementation details (optional)
there are three ways to implement this maybe make them all options
- Send Control+C signal and do nothing if processes don't respond. If nothing is done then the user clicks the X button a second time send a SIGTERM(CONTROL_CLOSE_EVENT) that gives the application 5s to respond before closing
- Send Control+C signal and do nothing for 5-8s, After that prompt the user if they are sure they want to kill all processes inside before closing like macOs but not immediate as we want CLI programs to try and save on regular shutdown
- Add an option to always use Control_CLOSE_EVENT (SIGTERM) on X button for those users that don't want the prompt and don't care about data loss / file corruption
Contributor guide
Research direction
No files, tests, or entry points are named. Start by clarifying whether the requested behavior applies to the Windows Terminal window, individual tabs, or both, and which of the three close-handling options is intended. Done should include an agreed signal sequence and confirmation of behavior when processes do not respond.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, operating-systems
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100