microsoft / microsoft/terminal

Consider consolidating UI helpers into a Microsoft.Terminal.UI namespace/dll

Open
#15,058 2 comments 0 reactions 1 assignee View on GitHub

@DHowett is already working on this.

Since Mar 29, 2023.

Area-CodeHealth Issue-Task Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

work branch https://github.com/microsoft/terminal/tree/dev/duhowett/m.t.ui

We have some UI helpers flung all about the Terminal code, including in Terminal.Settings.Model, that could be consolidated.

  • TerminalApp
    • EmptyStringVisibilityConverter
  • TerminalSettingsEditor
    • Converters
      • Including a duplicate EmptyStringVisibilityConverter equivalent; deduplicate these!
  • TerminalSettingsModel
    • IconPathConverter

I originally authored it to contain a resource string markup extension as detailed in an APS blog post. That'll help us get rid of all the places where we load resource strings in code because they couldn't be bound in XAML.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.