microsoft / microsoft/terminal

Our MinMaxCloseControl's resources are all messed up

Open
#14,951 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-i18n Help Wanted Issue-Bug Issue-Task Needs-Tag-Fix Priority-3 Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

### Windows Terminal version

1.16.10262.0

### Windows build number

10.0.22621.0

### Other Software

_No response_

### Steps to reproduce

Hover the center of the windows' close button.

### Expected Behavior

A tooltip should appear in the local language's equivalent of "Close".

### Actual Behavior

Hovering the button shows two tooltips fade in, first the English one, then the local language's one.

![image](https://user-images.githubusercontent.com/24683548/222844614-a1996e5e-7ff6-41bb-ae21-836e01730ecc.png)

https://user-images.githubusercontent.com/24683548/222845299-ac3d37c1-e5fb-4a34-997a-f71d086ca9cd.mp4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the duplicate tooltip when hovering the center of the Windows Terminal close button, then inspect the MinMaxCloseControl resources involved in that hover state. Done means hovering the button shows only one tooltip, using the equivalent of “Close” in the local language.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.