microsoft / microsoft/terminal

Tab background should use opacity from profile

Open
#14,833 3 comments 6 reactions 0 assignees View on GitHub
Area-Theming Issue-Feature Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

The tab background color is picked from the current profile, but the opacity is not.
Which makes the tabs appear even darker than the actual tab contents.

![terminal-1](https://user-images.githubusercontent.com/6878281/218296616-576a83f9-6c0c-41c8-bee3-6cb9264b1491.png) ![terminal-2](https://user-images.githubusercontent.com/6878281/218296617-a690d986-d841-4142-a8d8-9a52959530a5.png)

_Light theme and GitBash on Solarized Dark with 70 opacity and useAcrylic.
Windows-Terminal Version: 1.16.10262.0_

Setting RGBA color values for tab colors in themes already works.
But then you lose the color hue from the current profile.

Hovering over an inactive tab comes close to the expected result.

![terminal-3](https://user-images.githubusercontent.com/6878281/218299141-6e628c30-717b-4777-a53b-24b61ebc19d5.png)

This is somewhat related to #14026 and #14815.

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue in Windows Terminal 1.16.10262.0 using a profile with 70% opacity and useAcrylic, comparing the tab background with the tab contents. Trace the tab background handling and verify that the profile opacity affects the tab color while preserving the profile hue; the issue is done when the tab appearance matches the expected opacity.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.