microsoft / microsoft/terminal

Quake window hotkey is not handled correctly when pressed twice quickly

Open
#14,724 0 comments 0 reactions 0 assignees View on GitHub
Area-Windowing Issue-Bug Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

### Windows Terminal version

1.16.3463.0

### Windows build number

10.0.19043.2364

### Other Software

_No response_

### Steps to reproduce

There's a bug where pressing the quake hotkey too quickly bugs out. If the window is open and you press the hotkey twice it will close > open > close instead of just close > open. This doesn't if you wait long enough for the second press. It also doesn't happen if you hit it twice really fast. But there's a pretty big range between about 100 and 300 ms where this bug occurs.

* Open the quake window
* Press the quake hotkey
* Press the quake hotkey again after 100-300 ms

### Expected Behavior

After pressing the hotkey twice the quake window should be open.

### Actual Behavior

The quake window is not open.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the timing-dependent behavior on Windows Terminal 1.16.3463.0 using the listed 100–300 ms interval. Trace the quake hotkey handling and verify that two presses leave the quake window open, including tests for slower and faster intervals.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.