microsoft / microsoft/terminal
[JAWS] Search results read "results found" instead of something useful
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
### Windows Terminal version
1.16.2642
### Windows build number
_No response_
### Other Software
JAWS (though this probably repros with any screen reader)
### Steps to reproduce
1. generate text (i.e. `ls`)
2. open search dialog (ctrl+shift+f)
3. search for something (i.e. `text`) NOTE: make sure there are results!
### Expected Behavior
the line of text should be read (i.e. `this is example text` where "text" is selected)
This gives context to the user
### Actual Behavior
reads "results available"
Most likely caused by https://github.com/microsoft/terminal/pull/12301
## Other feedback
- "no results found" is good!
- "findMatch" should work the exact same way
- when we loop around the buffer, we should say "back to top/bottom"
Contributor guide
Research direction
Start with the search dialog opened by Ctrl+Shift+F and review the behavior introduced in PR #12301. Reproduce the result announcement with JAWS, then verify that a match reads its surrounding line, no results remains clear, and wraparound announces the new buffer position.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- accessibility
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100