microsoft / microsoft/terminal

High GPU usage for Atlas engine

Open
#14,078 4 comments 0 reactions 0 assignees View on GitHub
Area-AtlasEngine Needs-Tag-Fix Resolution-External
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

### Windows Terminal version

1.16.2524.0 and 1.16.2523.0

### Windows build number

10.0.22000.978

### Other Software

[Serilog](https://github.com/serilog/serilog)

PC is an [ ROG Zephyrus M16 (2022) GU603 GU603ZW-K8104W ](https://rog.asus.com/laptops/rog-zephyrus/rog-zephyrus-m16-2022-series/spec/)

CPU is an i9-12900H and terminal is using the integrated GPU.

### Steps to reproduce

I have 2 C# applications that are both using the Serilog logging library, outputting a large volume of colourised logs. The first one is a console application that will receive some data, log it to the console and then forward it to an ASP.NET Core. I have both of these applications running in 2 different tabs inside of a terminal window.

A typical log output from the console application is something like this and messages like these are printed out several times per second.
![image](https://user-images.githubusercontent.com/8287765/192169731-bf1482f4-8c55-4fb2-bf9b-9c4e0d942cf1.png)

There are also some EF Core logs scattered throughout the console app that are printing out SQL statements that are running.

In the ASP.NET Core application it logs the incoming requests that are received from the CLI application which prints some metadata and some SQL that is being performed. There are several of these requests per second as well.

### Expected Behavior

With the Atlas renderer disabled, GPU usage according to task manager is this.
![image](https://user-images.githubusercontent.com/8287765/192170076-00008093-bcf5-4bc3-af6b-b83590732ff8.png)

### Actual Behavior

With the Atlas renderer enabled the GPU usage is now reported as this.
![image](https://user-images.githubusercontent.com/8287765/192170106-8cdf11f3-529d-4eac-aec4-f895d53a9fd1.png)

Due to the high GPU usage, all applications on graphical applications on the system will run a bit slowly.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the report on Windows Terminal 1.16.2524.0 with two tabs producing high-volume colourised logs, comparing GPU usage with the Atlas renderer enabled and disabled. Investigate the Atlas rendering path and verify the fix by confirming that comparable logging no longer causes excessive GPU usage or slows other graphical applications.

Written by the indexing model from the issue text.

Assessment

Domain
cli, operating-systems, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.