microsoft / microsoft/terminal

Key cap names are not localized in the new tab menu

Open
#13,815 1 comment 0 reactions 0 assignees View on GitHub
Area-Localization Area-UserInterface Issue-Bug Priority-2 Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

Ported from MSFT:39044461

This block of code does not use localized key names (so in German, `Ctrl` should be `Strg` but is `Ctrl`)

https://github.com/microsoft/terminal/blob/70313db246c42fac3ec57eaec3eb1294563c8583/src/cascadia/TerminalApp/TerminalPage.cpp#L2000-L2018

This code is a hack to workaround a permanent WinUI issue . . .

Contributor guide

Open the contributing guide

Research direction

Start in src/cascadia/TerminalApp/TerminalPage.cpp at lines 2000–2018 and inspect how the new tab menu builds key names. Check the existing WinUI workaround and localization handling, then verify that German displays the localized Ctrl name, “Strg,” instead of “Ctrl.”

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
localization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.