microsoft / microsoft/terminal

`tab.showCloseButton: hover|never` + `tabWidthMode: titleLength` should have some padding on the left of the tab

Open
#13,725 4 comments 1 reaction 0 assignees View on GitHub
Area-Theming Help Wanted Issue-Bug Priority-3 Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

* [ ] There should be a bit more space to the right of the tab title to match the left side (next to icon)
![image](https://user-images.githubusercontent.com/18356694/184159398-5ad2da19-c0ef-44b6-bf8b-85df2d18bb1d.png)

Fixed in 1.16

### From 1.16.2142.0 bash on Aug 2nd

* [x] Gap between inactive tabs and content
![image](https://user-images.githubusercontent.com/18356694/184158584-f2f512f9-8f78-498e-8425-ceeab1c3945f.png)
- This might be related to the gap I was seeing in 2.8. Maybe fixing this (or at least understanding the root cause) might alleviate that issue as well.
- Tracked upstream at: https://github.com/microsoft/microsoft-ui-xaml/issues/7674
* [x] A light tabRow.BG in dark mode causes the chevron to be white:
![image](https://user-images.githubusercontent.com/18356694/184158730-27c59deb-e744-4246-9ed3-bc6fb9d734d5.png)
* fixed in #13871
* [x] We need to remove `useMica`
* [x] With "tab.background" set to "terminalBackground":
* [x] Hover over a terminal tab -> the tab color doesn't change/give any visual feedback that it is being hovered over
* [x] Hover over a settings tab -> the tab color does change/give visual feedback

### additional

* [x] With `"tab.showCloseButton"` set to `"hover"`: Height of inactive tabs change upon hover - (can't seem to post a GIF in OneNote so try it yourself)
* Mike couldn't repro this, so maybe someone else can?

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue with `tab.showCloseButton` set to `hover` or `never` and `tabWidthMode` set to `titleLength`, then inspect the tab layout involved in Windows Terminal. Compare the left and right spacing around the tab title, and consider the work done when the right-side padding visually matches the left side without regressing close-button behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.