microsoft / microsoft/terminal
Marks on scrollbar: smarter navigation (center the mark vertically)
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Description of the new feature/enhancement
Since #12948 we have the long-awaited marks on the scrollbar, along with the possibility to navigate between them.
Unfortunately, the navigation isn't very smart yet. When jumping to the previous/next mark, the window area merely scrolls such that the marked line becomes visible.
It would be much nicer if
- the marked line would end up somewhere near the middle of the window – more often than not, what I'm interested in is the content directly above or below the mark, and this would then be immediately visible.
- the line was highlighted (briefly) after the navigation action – this would make it easy to immediately find the marked line visually.
Proposed technical implementation details (optional)
The »jump to mark« command should scroll the window area such that the target line ends up near the middle of the screen whenever possible. A temporary highlight effect should be used to visually guide the user to the target line.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the existing jump-to-mark command and scrollbar mark navigation behavior. Identify how the target line is brought into view, then verify that navigation centers it when possible and briefly highlights the line afterward.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100