microsoft / microsoft/terminal

Move InputStateMachineEngine and InteractDispatch into Host

Open
#13,036 0 comments 0 reactions 0 assignees View on GitHub
Area-CodeHealth Issue-Task Priority-3 Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

These things aren't used in Terminal, and get dropped by LTO anyway. The work in #13024 drives `terminal/adapter` and, to an extent, `terminal/parser` closer to being fully-shared components, so maybe we should beef up that boundary.

Contributor guide

Open the contributing guide

Research direction

Start by tracing InputStateMachineEngine and InteractDispatch and reviewing the terminal/adapter and terminal/parser boundaries described in the issue. Compare their current use in Terminal with the Host boundary, using #13024 for context. Done means the components are moved into Host while the shared terminal components remain correctly separated and the project builds successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.