microsoft / microsoft/terminal
Test string-view forwarding improvements in MSVC
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
VSO-1265022 and VSO-1526191 improve MSVC's code generation when accessing 128-bit types passed by value. After these have been released in Visual Studio we should retest the performance
* in general as we use a lot of string-views throughout the code base
* after reverting ee3259847af233d24b517c9c1c252c815b6e990e as that commit should optimally not be necessary anymore
AMD and especially Intel Atom CPUs should be most affected by these improvements, as both have slower SSE loads than other, higher end Intel CPUs AFAIK.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by confirming that Visual Studio includes the VSO-1265022 and VSO-1526191 code-generation improvements, then review commit ee3259847af233d24b517c9c1c252c815b6e990e. Retest string-view performance generally and after reverting that commit, prioritizing AMD and Intel Atom CPUs; done means the results show whether the revert is still necessary.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- performance, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100