microsoft / microsoft/terminal
Remove the `Feature_IsolatedMonarchMode` fix
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
See:
* MSFT:38540483
* #12774
* #12825
* #12856
in #12825 we tried out two fixes blindly to fix this crash. Turns out, neither was the real root cause. #12856 did fix it though.
We should probably remove the "big hammer" fix of falling back to the isolated monarch, and just do the "little hammer" one. Or heck maybe even neither, since there seems to be no difference here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Begin at the implementation and call sites of `Feature_IsolatedMonarchMode`, then read #12774, #12825, and #12856 to understand which fixes remain relevant. Done means the isolated-Monarch fallback is removed, or both fixes are deliberately removed if the referenced evidence supports that choice, without reintroducing the crash.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, operating-systems
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100