microsoft / microsoft/terminal
We don't update LPWINDOWPOS flags during `WM_WINDOWPOSCHANGED`, maybe we should?
Open
Area-CodeHealth
Area-Windowing
Help Wanted
Issue-Bug
Priority-3
Product-Terminal
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
https://github.com/microsoft/terminal/blob/41ef5554f5cb946c4a48e2b8db791265c7217fce/src/cascadia/WindowsTerminal/IslandWindow.cpp#L592
Since size is changed here shouldn't we clear the SWP_NOSIZE bit in lpwpos->flags?
Contributor guide
Research direction
Start at IslandWindow.cpp around line 592 and trace the WM_WINDOWPOSCHANGED handling, focusing on how the LPWINDOWPOS flags and SWP_NOSIZE relate to the size change. Confirm the expected flag state for this message and document or implement the agreed behavior, with validation in the relevant Windows Terminal test coverage if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100