microsoft / microsoft/terminal
Tab position is not restored for `restoreLastClosed` action
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
The problem with this is the tab position is not restored, if tab closed is first one, the restored tab is the last one.
the position should also be restored
_Originally posted by @swinder0161 in https://github.com/microsoft/terminal/issues/960#issuecomment-1098341305_
This might be tricky - we might be able to remember the location of the tab, but I'd expect it to work weird if the tabs get reordered before restoring the tab. This might be acceptable though.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the `restoreLastClosed` action and how a closed tab's location is remembered. Reproduce the case where the first tab is closed and restored, then define completion as restoring it to its prior position, while checking behavior if tabs are reordered before restoration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100