microsoft / microsoft/terminal
UI nits from WinUI Controlsv2
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
In Terminal 1.13 we updated our version of WinUI to closer align with the Windows 11 styles. (in technical terms, we updated to ControlsV2). This had a variety of minor visual artifacts associated with it:
- #12395
- upstream discussion: https://github.com/microsoft/microsoft-ui-xaml/issues/6684
- potential workaround: https://github.com/microsoft/terminal/issues/9218
- fixed in #12608
- New Tab icons aren't quite the right size: https://github.com/microsoft/terminal/issues/12395#issuecomment-1030874694
- #12398
- #12350
- #12388
- Also includes:
- #13285
- #13068
- #9775
- #13428
- Colors are inconsistent between active tab, nav view, and tab content

- But actually, that's just how it is in Xaml Controls Gallery too:

- #12574
- #13495
Relevant PRS:
- #12241
- #11720
- #12144
- #12287
- #12326
- #12374
- #12376
- #12381
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the unchecked items in this tracking issue, especially the new tab icon sizing concern and #12388 with its remaining subitems. Follow the referenced issue comments and upstream WinUI discussions first, then use the linked related issues and PRs to determine which artifacts remain. Done means the remaining unchecked Controlsv2 visual issues are resolved or separately tracked.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100