microsoft / microsoft/terminal

Add the ability to mark a profile as "read only"

Open
#12,341 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Settings Issue-Feature Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

From a mail thread.

Say an application author wants to add a fragment profile for their app. They want to turn on a bunch of specific settings for that app, like, closeOnExit. But they REALLY REALLY don't want users overriding those properties. The app author should be able to specify some way that indicates that this profile can no longer be layered on top of.

addenda:

  • when we have arbitrary profile layering (#2933 is similar but not what I was thinking), then does readOnly prevent a user profile from being layered by other profiles?
  • Do we throw a warning when the user tries to add properties in their settings to a readonly profile? (probably)
  • What happens if they mark profiles.defaults as readonly? (probably warn them, because that's an obvious footgun)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how profile layering and profiles.defaults are represented and validated. Resolve whether read-only profiles block later layering, how user overrides are reported, and what happens when profiles.defaults is marked read-only; done means the behavior and warnings are defined and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.