microsoft / microsoft/terminal
[Terminal> Set tab color]: 'Custom' control name is not descriptive, and role defined is incorrect.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
Windows Terminal version
1.12.3472.0
Windows build number
10.0.22504.1010
Other Software
Test Environment:
OS: Windows 11 Version Dev (OS Build 22504.1010)
App: Windows Terminal Preview
Screen Reader: Narrator
Tool: Accessibility Insights for Windows Version 1.1.1741.1
Steps to reproduce
Repro Steps:
- Open Windows Terminal.
- Open Settings page using 'Ctr+,'.
- Activate 'Actions' tab and then Add a new actions 'Set tab color' with shortcut key 'Ctrl + Shift + c'.
- Open Narrator using 'Win + Ctrl + Enter' keys.
- navigate inside Terminal window.
- Press 'Ctrl + Shift + c' keys, then navigate to 'Custom' control inside Set tab color pop-up using tab key.
- Observe the issues.
User Experience:
Screen Reader users UX will not be good as control name is not descriptive so they will not be able to know the purpose of controls also role properties does not match visual structure.
Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value
Attachments:
'Custom' control name is not descriptive, and role defined is incorrect. (2).zip
Expected Behavior
'Custom' ontrol name should be more descriptive, and correct role should be defined.
.i.e. For Collapsed 'Custom' control Screen Reader should announce 'Custom Tab Colors button Collapsed' and For Expanded 'Custom' control Screen Reader should announce 'Custom Tab Colors button Expanded'
Actual Behavior
'Custom' control name is not descriptive, and role defined is incorrect.
i.e. For Collapsed 'Custom' control Screen Reader should announce 'Custom Button off' and For Expanded 'Custom' control Screen Reader should announce 'Custom Button On'
Observation: Issue repro with NVDA and JAWS Screen Reader.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Set tab color flow and navigating to the Custom control with Narrator, NVDA, or JAWS. Inspect the control's accessible name and role, then verify that collapsed and expanded states announce “Custom Tab Colors button” with the corresponding state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- accessibility
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100