microsoft / microsoft/terminal

[Settings> Add New Profile]: 'Discard changes' control performing 'Delete profile' functionality inside newly created profile.

Open
#12,039 2 comments 0 reactions 0 assignees View on GitHub
A11yCO A11yUsable Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Bug Product-Terminal WindowsTerminal_Win32
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

### Windows Terminal version

1.12.3472.0

### Windows build number

10.0.22504.1010

### Other Software

**Test Environment:**
OS: Windows 11 Version Dev (OS Build 22504.1010)
App: Windows Terminal Preview
Screen Reader: Narrator

### Steps to reproduce

**Repro Steps:**
Open Windows Terminal.
Open Settings page using 'Ctr+,'.
Activate 'Add a new profile' tab, then activate 'New Empty profile' or 'Duplicate' button.
Then activate 'Discard Changes' button inside newly created profile.
Observe the issue.

**User Experience:**
All users UX will not be good if inappropriate functionality is performed on activating a control.

**Attachments:**
[Profile get deleted When user activate 'Discard changes' control in newly created profile and Keyboard focus jumps to 'Discard Changes' inside Startup page..zip](https://github.com/microsoft/terminal/files/7778817/Profile.get.deleted.When.user.activate.Discard.changes.control.in.newly.created.profile.and.Keyboard.focus.jumps.to.Discard.Changes.inside.Startup.page.zip)

### Expected Behavior

'Discard changes' control should not perform 'Delete profile' functionality inside newly created profile.

### Actual Behavior

'Discard changes' control performing 'Delete profile' functionality inside newly created profile. Profile get deleted When user activate 'Discard changes' control in newly created profile and Keyboard focus jumps to 'Discard Changes' inside Startup page..

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the flow from the Settings page: Add a new profile, create a New Empty profile or duplicate one, then activate Discard Changes. Trace the settings controls involved and verify that Discard Changes leaves the newly created profile intact without moving focus to the Startup page.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.