microsoft / microsoft/terminal
[Settings> Color Schemes/Actions]: Accessible name is not descriptive for 'Add New', 'Rename', 'Add new', 'Edit', 'Accept', 'Cancel' and 'Delete' buttons inside Color Schemes & Actions page.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
### Windows Terminal version
1.12.3472.0
### Windows build number
10.0.22504.1010
### Other Software
Test Environment:
OS: Windows 11 Version Dev (OS Build 22504.1010)
App: Windows Terminal Preview
Screen Reader: Narrator
Tool: Accessibility Insights for Windows Version 1.1.1741.1
### Steps to reproduce
**Repro Steps:**
1. Open Windows Terminal.
2. Open Settings page using 'Ctr+,'.
3. Open Narrator using 'Win+Ctrl+ Enter' key.
4. Now navigate to 'Add New', 'Rename', 'Add new', 'Edit', 'Accept', 'Cancel' and 'Delete' buttons inside Color Schemes & Actions page and observe the issue.
**User Experience:**
Screen Reader users UX will not be good if control name is not descriptive.
**Guideline Reference:**
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value
**Attachments:**
[Accessible name is not descriptive for buttons.zip](https://github.com/microsoft/terminal/files/7751151/Accessible.name.is.not.descriptive.for.buttons.zip)
### Expected Behavior
Accessible name should be descriptive i.e. 'Add New Color Schemes', 'Rename Color Schemes', 'Add new Actions', 'Edit Copy Text Actions', 'Accept Actions', 'Cancel Actions' and 'Delete Actions' buttons inside Color Schemes & Actions page.
### Actual Behavior
Accessible name is not descriptive for 'Add New', 'Rename', 'Add new', 'Edit', 'Accept', 'Cancel' and 'Delete' buttons inside Color Schemes & Actions page.
i.e. For 'Edit' button Screen Reader is only announcing 'Edit' button.
**Observation:** Same issue repro with NVDA Screen Reader.
Contributor guide
Research direction
Reproduce the issue on the Settings > Color Schemes & Actions page with Narrator or NVDA, then inspect the controls exposing the Add New, Rename, Add new, Edit, Accept, Cancel, and Delete labels. Update their accessible names so each identifies the related color scheme or action, and verify the expected names with a screen reader.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- accessibility, desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100