microsoft / microsoft/terminal
[Command Palette] : Keyboard focus is moving on to some hidden item, while navigating via tab key inside Command palette window.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
### Windows Terminal version
1.12.3472.0
### Windows build number
22509.1011
### Other Software
**Test Environment:**
OS: Windows 11 Version Dev (OS Build 22509.1011)
App: Windows Terminal Preview
### Steps to reproduce
**Repro steps :**
1.Open Windows Terminal.
2.Open the 'Command Palette' using 'Ctrl + Shift + P' keys.
3.navigate in the page via tab key & observe the issue.
**User Experience**
Users who rely on keyboard will get impacted here & may feel difficulty in tracking the focused element, if focus moves on to hidden element on navigating in 'Command palette' window.
**Guideline reference**
https://www.w3.org/TR/WCAG21/#focus-order
**Attachment :**
[Focus is moving on to hidden element in command palette window.zip](https://github.com/microsoft/terminal/files/7729273/Focus.is.moving.on.to.hidden.element.in.command.palette.window.zip)
### Expected Behavior
Keyboard focus should not move on to some hidden item, while navigating via tab key inside Command palette window.
**Expected focus order :** after 'Type a command name' edit, focus should move on to 'First command' & then after pressing tab key focus should land on 'Type a command name' edit', .......
### Actual Behavior
**Actual focus order is :** First focus is landing on 'Type a command name' edit & then after moving on to 'First command' & then on pressing tab key focus is moving on to hidden element'.
-->When 'Settings' tab is open, when focus is on 'Hidden element' - On pressing enter, focus is landing on 'Close/open' navigation button.
-->When 'Windows power shell' is open, when focus is on 'Hidden element'- on pressing enter, focus is landing on 'Power shell'.
Contributor guide
Research direction
Start by reproducing the issue in the Command Palette with the listed Windows Terminal and Windows build versions, then trace the focus order for the palette controls. No source file or test is named in the report. Done means Tab moves from the command-name edit to the first command and cycles back without landing on a hidden element.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- accessibility, desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100