microsoft / microsoft/terminal
[Settings>Actions] : Focus is not visible properly on 'Shortcut' edit field.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
### Windows Terminal version
1.12.3472.0
### Windows build number
22509.1011
### Other Software
**Test Environment: **
OS: Windows 11 Version Dev (OS Build 22509.1011)
App: Windows Terminal Preview
Screen Reader: Narrator
### Steps to reproduce
**Repro Steps: **
1.Open Windows Terminal.
2.Open Settings page using 'Ctr+,'
3.Navigate to 'actions' list-item via 'Up/down' arrow keys & press enter.
4.Now Navigate to Actions present in the right pane via down arrow key.
5.Navigate to 'Edit' button present for any 'Action' via tab key & press enter.
6.A pop-up will gets open & navigate to 'Shortcut' edit field via tab key.
7.Verify whether focus is visible properly on 'Shortcut' edit field or not.
**User Experience: **
Users who rely on keyboard will get impacted here & may fail to track the currently focused element, if focus is not visible properly on 'Shortcut' edit field.
**Guideline Reference: **
https://www.w3.org/TR/WCAG21/#focus-visible
Attachments:
[Focus is not visible properly on shortcut edit field.zip](https://github.com/microsoft/terminal/files/7726819/Focus.is.not.visible.properly.on.shortcut.listeners.edit.field.zip)
### Expected Behavior
Focus should be visible properly on 'Shortcut' edit field. Focus indicator should be provided as outline for better visibility.
### Actual Behavior
'Inline' focus is provided for 'Shortcut' edit field, due to this user is unable to recognize that edit field is focused when focus is on 'Shortcut' edit field.
Contributor guide
Research direction
Reproduce the issue from Settings > Actions by opening an action's Shortcut edit field and navigating with the keyboard. Inspect the focus styling for that field; done means the focused control has a clearly visible outline and satisfies the referenced WCAG focus-visible expectation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100