microsoft / microsoft/terminal
Add a test to cover closing two sibling panes (near) simultaneously
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
- Dependent upon #1042.
I'm adding code in #825 to try and make sure that when a pane is closed nearly synchronously with a sibling, it'll close properly. However, manually testing this is really hard, so I'm filing a follow-up task to make sure that's implemented correctly.
I'll need the test framework stuff I'm working on in 1042 to land first though, so this can be done in a unittest.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the test-framework work in #1042 and the pane-closing code in #825, since this issue depends on both. Add a unit test for closing two sibling panes nearly simultaneously, and confirm the panes close correctly without relying on manual testing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100