microsoft / microsoft/terminal

Fragment fontFace not detecting correctly

Open
#10,790 6 comments 0 reactions 0 assignees View on GitHub
Area-Settings Issue-Docs Priority-3 Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

### Windows Terminal version (or Windows build number)

1.9.1942.0

### Other Software

Oh-My-Posh (latest)

### Steps to reproduce

Set a default fontFace in settings.json
Set different fontFace in {fragments}.json

Review if font is displaying correctly.

If not, disable the default fontFace and revalidate.

### Expected Behavior

The expected behavior is that the fontFace that is set for a profile in the {Fragments}.json file is indeed using the desired font.

### Actual Behavior

When a default fontFace is set then the fontFace that is set as part of the fragment is ignored.

Removing the default fontFace string enables the fontFace that was set in the fragment to be used.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in Windows Terminal 1.9.1942.0 with a default fontFace in settings.json and a different fontFace in {fragments}.json, using the described Oh-My-Posh setup. Trace how the default and fragment profile settings are combined; done means the fragment's fontFace is used even when a default fontFace is present.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.