microsoft / microsoft/terminal
Memory leak and other issues when saving settings
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 105k
- Forks
- 9.6k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 29
Description
### Windows Terminal version (or Windows build number)
1.8.1521.0 (also observed on source build 2021-07-11)
### Other Software
_No response_
### Steps to reproduce
Open the settings dialog and spam click save. No option needs to be changed.
Video: 13 seconds in, the settings could not be reloaded from file (not sure if it is not loading or file corruption).
https://user-images.githubusercontent.com/2277504/125179830-a31f3a00-e1f2-11eb-8b6f-6f6aa07896c5.mp4
### Expected Behavior
Memory stays roughly the same, settings file can be loaded after saving, main UI does not extend past its borders.
### Actual Behavior
Memory grows and is not reclaimed, settings file can sometimes not be loaded after saving, UI grows past its borders during reloading.
(Second and third only discovered after deciding to record a video for the memory leak)
Not sure if you want separate tracking issues for these, let me know.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the problem by opening the settings dialog and repeatedly clicking Save, using the linked video as a reference. Trace the settings save and reload paths and the UI resizing observed during reload; done means memory remains stable, the settings file reloads successfully, and the main UI stays within its borders.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100