microsoft / microsoft/terminal

`WriteCharsLegacy` performance issues caused by `NotifyConsoleUpdateSimpleEvent`

Open
#10,528 19 comments 0 reactions 0 assignees View on GitHub
Area-Performance Help Wanted Issue-Task Product-Conhost
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

# Description of the new feature/enhancement

I know this is a issue a long time ago, but haven't got the chance to talk about it.

This is typical WPR trace of `OpenConsole` with output-heavy programs.

![image](https://user-images.githubusercontent.com/4710575/123777797-21323580-d903-11eb-93d3-3b46acc43db4.png)

# Proposed technical implementation details (optional)

Perhaps throttling the event?

Contributor guide

Open the contributing guide

Research direction

Start with the `WriteCharsLegacy` entry point and its calls to `NotifyConsoleUpdateSimpleEvent`, using the attached WPR trace as the performance baseline. Determine where the event cost occurs for output-heavy programs and establish a reproducible comparison before proposing a throttling approach. Done means a measured improvement with behavior preserved, but no test or source file is identified in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.