microsoft / microsoft/terminal

DxRenderer should eat "concealed" text

Open
#10,511 3 comments 0 reactions 0 assignees View on GitHub
Area-Rendering Help Wanted Issue-Task Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

# Description of the new feature/enhancement

Invisible text is generally rendered as text with a foreground color equal to the background color. This can be repro'd as a part of https://github.com/jdebp/terminal-tests/tree/master/PowerShell).

This makes it _not_ look invisible, however, because we apply the acrylic texture to the background, but not the foreground.

# Proposed technical implementation details (optional)

Just make the renderer _not_ render the invisible text. Ignore it completely.

Contributor guide

Open the contributing guide

Research direction

Start by locating DxRenderer in the Windows Terminal codebase and reproduce the concealed-text case described using the terminal-tests PowerShell examples. Trace how text whose foreground matches the background is rendered, then verify that such text is omitted while visible text remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.