microsoft / microsoft/terminal

Make shaders not follow padding; consider moving padding into the renderer

Open
#10,422 5 comments 2 reactions 0 assignees View on GitHub
Area-Rendering Issue-Feature Priority-2 Product-Conhost Product-Terminal
Dominant language
C++
Stars
105k
Forks
9.6k
Avg merge
3d 17h
Merged PRs (30d)
29

Description

# Description of the new feature/enhancement

I'm not sure whether this is by design or not but making the shader only render inside the padded area makes it, in my opinion, look less good. I like my text to be padded without having my shaders cut off where the text area ends.

For smaller paddings one could currently just move the texture a little by sampling at an offset but this will break highlighting at a certain point.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how shader rendering applies the text area's padding and how highlighting is handled. The work is complete when shaders can render beyond the padded text area without breaking highlighting, while text padding remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.