Tabster doesn't set FOCUS_VISIBLE_ATTR to element when navigating from content-editable area
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 165
- Forks
- 42
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 9
Description
Hi,
We needs to shift focus from content-editable area to Popover and let Tabster handle the setting of FOCUS_VISIBLE_ATTR. Please see method "registerElementIfNavigating()" from https://github.com/microsoft/fluentui/blob/master/packages/react-components/react-tabster/src/focus/focusVisiblePolyfill.ts
Current Tabster only supports to set FOCUS_VISIBLE_ATTR when pressing TAB or currentActiveElement is not input/textarea/content-editable element. Please see "_shouldTriggerKeyboardNavigation()" from https://github.com/microsoft/keyborg/blob/main/src/Keyborg.ts
Thank you.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with registerElementIfNavigating() in packages/react-components/react-tabster/src/focus/focusVisiblePolyfill.ts and compare its behavior with _shouldTriggerKeyboardNavigation() in Keyborg.ts. Trace navigation from a content-editable area to a Popover, then verify that Tabster sets FOCUS_VISIBLE_ATTR on the destination element without changing the existing TAB behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100