microsoft / microsoft/tabster

Shadow DOM: implement a "getParent()" function to correctly walk up the DOM tree for elements in the shadow root

Open
#339 0 comments 0 reactions 1 assignee View on GitHub

@mshoho is already working on this.

Since Jan 25, 2024.

Dominant language
TypeScript
Stars
165
Forks
42
Avg merge
1d 11h
Merged PRs (30d)
9

Description

Tabster currently uses Node.parentElement to walk up the parents of a given element. This method will not walk up from shadow root (or from slotted elements).

We need to implement a "getParent(element)" function to handle elements inside shadow roots and slotted elements.

This is implemented

We need to validate it with tests and decide how to best integrate it into Tabster.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.