microsoft / microsoft/tabster

Mover ignores input from elements with `aria-expanded`

Open
#312 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
165
Forks
42
Avg merge
1d 11h
Merged PRs (30d)
9

Description

Problem description

When the useTableCompositeNavigation hook is used on a table, and when the aria-expanded attribute is applied on the table row, the arrow key navigation stops working.

Code example

import * as React from 'react';
import {
  useTableCompositeNavigation,
  Button,
} from '@fluentui/react-components';

export const TreeGrid: React.FC<IRecentMeetingsTreeRendererrerProps> = ({ recentMeetings }) => {
  const { tableRowTabsterAttribute, tableTabsterAttribute, onTableKeyDown } = useTableCompositeNavigation();

  return (
    <table
        role= "treegrid"
  {...tableTabsterAttribute }
      >
    <tbody>
    <tr
            role="row"
  tabIndex = { 0}
  aria - level={ 1 }
  aria - expanded={ true }
  {...tableRowTabsterAttribute }
          >
    <td
              role="gridcell"
  tabIndex = { 0}
  colSpan = { 4}
    > Meeting with manager < /td>
    < /tr>
    < tr
            role = "row"
  tabIndex = { 0}
  aria - level={ 2 }
  {...tableRowTabsterAttribute }
          >
    <td role="gridcell" tabIndex = { 0} > Re: meeting with manager < /td>
    < td role = "gridcell" > <Button>Agenda and notes < /Button></td >
      <td role="gridcell" > <Button>Chat with participants < /Button></td >
      <td role= "gridcell" > <Button>View recap < /Button></td >
        </tr>
        < tr
  role = "row"
  tabIndex = { 0}
  aria - level={ 2 }
  {...tableRowTabsterAttribute }
          >
    <td role="gridcell" tabIndex = { 0} > Re 2: meeting with manager < /td>
    < td role = "gridcell" > <Button>Agenda and notes < /Button></td >
      <td role="gridcell" > <Button>Chat with participants < /Button></td >
      <td role= "gridcell" > <Button>View recap < /Button></td >
        </tr>
        < /tbody>
        < /table>

  );
};

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the useTableCompositeNavigation hook and reproduce the table example with a row carrying aria-expanded. Trace why arrow-key navigation stops working for that row. Done means table navigation continues to work when aria-expanded is present, while preserving the behavior shown for the other rows.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.