(feat) Restorer: investigate allowing child removal to trigger focus restoration in Safari & Firefox
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 165
- Forks
- 42
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 9
Description
Related to #305 -- with the fix in #306, Restorer will work in Safari & Firefox if the root node itself is removed from the DOM, but not if a child node containing document.activeElement is removed (note - CSS changes like display: none will still work, only DOM removal is an issue).
This seems like more of a minor use case/feature to support, since the primary use case is likely removing the root node. This issue is for tracking & to not lose the edge case after #306 is closed. Discussed w/ @ling1726
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issues #305 and #306 and the Restorer behavior they describe. Investigate child-node removal containing document.activeElement in Safari and Firefox; done means focus restoration works for that case while preserving the existing root-node removal behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- accessibility, frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100