[Bug] Deloser throws error when a form has an input with name `id`
Open
Nobody has claimed this yet.
bug
- Dominant language
- TypeScript
- Stars
- 165
- Forks
- 42
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 9
Description
https://github.com/microsoft/tabster/blob/master/src/Deloser.ts#L299
This check has a false positive for forms with an input named id since element.id will point to the input element in the form.
Sandbox for reproduction: https://codesandbox.io/s/agitated-khorana-hzqyu2?file=/src/index.tsx
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/Deloser.ts line 299 and reproduce the false positive using the linked CodeSandbox. Check how a form control named id affects the existing element.id check. Done means forms containing an input named id no longer trigger the erroneous Deloser error, while the intended check still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- accessibility
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100